OSP Projects

Fulfillment – Daily Changelog – October 27, 2025

Written by

Mark

in

,

Changelog – October 27, 2025

🐛 Critical Bug Fix

Order Type Filtering System Fixed

  • Problem Identified: Order type filtering on orders page was not working correctly
  • Filters showed no results even when matching orders existed
  • Found 9 orders (4 pending, 5 invoiced) missing order_type_id values
  • LEFT JOIN to order_types table returned NULL for orders without type assignment
  • Filter query looking for ot.slug = 'print-on-demand' couldn’t match NULL values

Solution Implemented

  • Bulk Order Type Assignment: Ran scripts/assign-order-types.js to fix missing order types
  • Analyzed line items for each order to determine correct type
  • Successfully assigned types to all 9 orders:
    • 1 print-on-demand order (#5480)
    • 7 raffle-sticker orders
    • 1 pod-raffle order (mixed POD + raffle sticker)
  • Database Verification: Confirmed all orders now have order_type_id populated
  • 0 orders remaining without order types
  • Filtering now works correctly for all order type combinations

System Verification

  • Automatic Assignment Confirmed: Verified that new orders automatically get order types assigned
  • Both Shopify orders and manual orders call assignOrderType() on creation
  • Future orders will not experience this issue
  • Filter Testing: Confirmed filtering by “Pending” + “Print-on-demand” now correctly shows order #5480

🔍 Investigation & Analysis

Database Query Analysis

  • SQL Filter Logic: Examined order filtering logic in /api/orders route
  • Filter correctly implemented using ot.slug = $N parameter
  • Issue was missing data, not broken code
  • Order Type Structure: Reviewed order_types table and relationships
  • Migration 027 added order_type_id to mama_tried_orders
  • Order types: print-on-demand, inventory, raffle-sticker, pod-raffle, mixed, external

Root Cause

  • Missing Migration: Some orders created before or during migration didn’t get order types assigned
  • Gaps in Automatic Assignment: While auto-assignment exists, some orders slipped through
  • Data Integrity: No mechanism to detect or alert on missing order types

🎯 Technical Details

Database Changes

-- Before Fix
SELECT COUNT(*) as orders_without_type 
FROM mama_tried_orders 
WHERE order_type_id IS NULL;
-- Result: 9 orders

-- After Fix  
SELECT COUNT(*) as orders_without_type 
FROM mama_tried_orders 
WHERE order_type_id IS NULL;
-- Result: 0 orders

Order Type Assignments

  • Order #5480 (Scott Coffey): print-on-demand
  • Order #5479 (Randy Gonzalez): raffle-sticker
  • Order #5478 (Nolan Hanke): raffle-sticker
  • Order #5477 (Anthony J Leone Jr): raffle-sticker
  • Order #5476 (Javier Snell): raffle-sticker
  • Order #5475 (Michael Holderbaum): raffle-sticker
  • Order #5474 (Roman Coronado): pod-raffle (2 line items)
  • Order #5473 (Tony Raphael): raffle-sticker
  • Order #5472 (Cristian Jimenez): raffle-sticker

📊 Impact

User Experience

  • ✅ Order Filtering Now Works: Users can successfully filter orders by type
  • ✅ Accurate Results: All matching orders appear in filtered views
  • ✅ Complete Data: Every order now properly categorized

System Health

  • ✅ Data Integrity Restored: All orders have proper type assignments
  • ✅ Future Protection: Automatic assignment prevents recurrence
  • ✅ Filter Reliability: Order type filters now function as designed

🔧 Scripts Used

Order Type Assignment Script

  • Script: scripts/assign-order-types.js
  • Function: Analyzes line items and assigns appropriate order type
  • Logic:
  • Examines product types in each order
  • Determines if POD, inventory, raffle-sticker, or mixed
  • Updates order_type_id based on item composition
  • Results: 9/9 orders successfully processed with no errors

📝 Notes

Prevention

  • Order type assignment already automated in order creation flow
  • This was a one-time fix for historical data
  • No code changes needed, only data correction

Testing

  • Verified filtering works with multiple combinations:
  • Status: pending + Type: print-on-demand ✅
  • Status: invoiced + Type: raffle-sticker ✅
  • Mixed filters ✅

Orders Fixed: 9
Script Runtime: < 1 second
Status: Complete – All orders now properly typed and filterable

More posts